This repository was archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 217
Move Chip
and RemovableChip
to components package
#11223
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release ZIP for this PR is accessible via:
Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
packages/components/chip/chip.tsx
packages/components/chip/removable-chip.tsx |
Size Change: +77.3 kB (+5%) 🔍 Total Size: 1.56 MB
ℹ️ View Unchanged
|
mikejolley
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: active filters
Issues related to the Active Filters block.
block: cart
Issues related to the cart block.
block: checkout
Issues related to the checkout block.
category: extensibility
Work involving adding or updating extensibility. Useful to combine with other scopes impacted.
focus: blocks
Specific work involving or impacting how blocks behave.
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR is based on #11214 (
update/checkbox-component
)Move
Chip
andRemovableChip
to components package and update instances where they're imported:Why
As more developers integrate their extensions with WooCommerce Blocks, the case for reusing components grows. This starts the ball rolling by creating a new package. Rather than recreating components developers can access wc.blocksComponents and get the ones we need.
Testing Instructions
x
on the chip.Screenshots or screencast
N/A
WooCommerce Visibility
Required:
Checklist
Required:
[type]
label or a[skip-changelog]
label.Conditional:
[skip-changelog]
label is not present).Changelog