Add authentication method to response interfaces and serializer #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `AuthenticationMethod` type to define various authentication methods. - Updated `AuthenticationResponse` and `AuthenticationResponseRaw` interfaces to include `authenticationMethod`. - Modified the `deserializeAuthenticationResponse` function to handle the new `authentication_method` field. - Updated tests to include `authenticationMethod` in session data setup.
cmatheson
approved these changes
Dec 16, 2025
| import { User, UserRaw } from "./user.interface"; | ||
| import { Impersonator, ImpersonatorRaw } from "./impersonator.interface"; | ||
|
|
||
| export type AuthenticationMethod = |
Collaborator
There was a problem hiding this comment.
the complete list of authentication methods is
SSO
Password
Passkey
AppleOAuth
BitbucketOAuth
CrossAppAuth
DiscordOAuth
ExternalAuth
GitHubOAuth
GitLabOAuth
GoogleOAuth
LinkedInOAuth
MicrosoftOAuth
SalesforceOAuth
SlackOAuth
VercelMarketplaceOAuth
VercelOAuth
XeroOAuth
MagicAuth
Impersonation
MigratedSession
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuthenticationMethodtype to define various authentication methods.AuthenticationResponseandAuthenticationResponseRawinterfaces to includeauthenticationMethod.deserializeAuthenticationResponsefunction to handle the newauthentication_methodfield.authenticationMethodin session data setup.