Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: Add destructuring to onRedirectCallback example to access state #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicknisi merged 1 commit into from
Jul 7, 2025
Merged

docs: Add destructuring to onRedirectCallback example to access state #67

nicknisi merged 1 commit into from
Jul 7, 2025

Conversation

@heatherfaerber
Copy link
Contributor

@heatherfaerber heatherfaerber commented Jul 7, 2025

Previously the Using State section of README showed an example accessing state object directly in onRedirectCallback:

<AuthKitProvider
      clientId="client_123"
      apiHostname="auth.example.com"
      onRedirectCallback={(state) => {
        // Access your data here
        if (state?.returnTo) {
          window.location.href = state.returnTo;
        }
      }}
    >

This correction shows state being destructured so it can be accessed:

<AuthKitProvider
      clientId="client_123"
      apiHostname="auth.example.com"
      onRedirectCallback={({ state }) => {
        // Access your data here
        if (state?.returnTo) {
          window.location.href = state.returnTo;
        }
      }}
    >

@heatherfaerber heatherfaerber requested a review from nicknisi July 7, 2025 14:10
greptile-apps[bot]
greptile-apps bot reviewed Jul 7, 2025
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updates the onRedirectCallback example in README.md to correctly demonstrate state object destructuring from the callback parameter.

  • Fixed misleading example in README.md that incorrectly showed direct state access, now properly shows destructuring { state } parameter in onRedirectCallback

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

nicknisi
nicknisi approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@nicknisi nicknisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nicknisi nicknisi merged commit 4374642 into main Jul 7, 2025
2 checks passed
@nicknisi nicknisi deleted the docs/readme-using-state-object branch July 7, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicknisi nicknisi nicknisi approved these changes

+1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@heatherfaerber @nicknisi