Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,14 @@ jobs:
test:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Job name test is misleading since it publishes to NPM. Consider renaming to publish or release for clarity.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 15:15

Comment:
**style:** Job name `test` is misleading since it publishes to NPM. Consider renaming to `publish` or `release` for clarity.

How can I resolve this? If you propose a fix, please make it concise.

name: Publish to NPM
runs-on: ubuntu-latest
permissions:
contents: read
id-token: write
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 24
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: CI workflow uses Node 20, but release uses Node 24. Consider aligning versions to catch potential compatibility issues during CI before release.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 25:25

Comment:
**style:** CI workflow uses Node 20, but release uses Node 24. Consider aligning versions to catch potential compatibility issues during CI before release.

How can I resolve this? If you propose a fix, please make it concise.

registry-url: "https://registry.npmjs.org"

- name: Install Dependencies
Expand All @@ -32,14 +35,10 @@ jobs:

- name: Push Release
if: ${{ !github.event.release.prerelease }}
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
run: |
npm publish --tag latest --access=public
npm publish --tag latest --access=public --provenance

- name: Push Pre-Release
if: ${{ github.event.release.prerelease }}
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
run: |
npm publish --tag next --access=public
npm publish --tag next --access=public --provenance