Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kendallstrautman
Copy link
Contributor

Description

Exports vault interfaces to fix #1397

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 24, 2025

Greptile Overview

Greptile Summary

Adds missing export * from './vault/interfaces' to make vault-related TypeScript interfaces accessible from the package root, resolving issue #1397 where developers couldn't import vault types without awkward workarounds.

  • Added export for vault interfaces (includes VaultObject, DataKey, KeyContext, etc.)
  • Alphabetically sorted roles and feature-flags exports for consistency
  • Follows established pattern used by other modules (roles, feature-flags, sso, etc.)

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a straightforward export statement following the exact same pattern as 11 other interface exports in the same file. No logic changes, no new dependencies, no security implications.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
src/index.ts 5/5 Added export for vault interfaces, fixing TypeScript import accessibility. Also alphabetically sorted roles and feature-flags exports.

Sequence Diagram

sequenceDiagram
    participant User as TypeScript Consumer
    participant Index as src/index.ts
    participant VaultInt as src/vault/interfaces/index.ts
    participant KeyInt as src/vault/interfaces/key.interface.ts
    participant ObjInt as src/vault/interfaces/object.interface.ts
    participant SecInt as src/vault/interfaces/secret.interface.ts
    
    User->>Index: import { VaultObject, DataKey } from '@workos-inc/node'
    Index->>VaultInt: export * from './vault/interfaces'
    VaultInt->>KeyInt: export * from './key.interface'
    VaultInt->>ObjInt: export * from './object.interface'
    VaultInt->>SecInt: export * from './secret.interface'
    KeyInt-->>VaultInt: KeyContext, DataKeyPair, DataKey
    ObjInt-->>VaultInt: ObjectDigest, VaultObject, ObjectMetadata, etc.
    SecInt-->>VaultInt: SecretContext (deprecated), VaultSecret (deprecated), etc.
    VaultInt-->>Index: All vault interfaces
    Index-->>User: Vault interfaces accessible at package root
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@kendallstrautman kendallstrautman merged commit bd856f5 into main Nov 24, 2025
5 checks passed
@kendallstrautman kendallstrautman deleted the kendallstrautman-patch-1 branch November 24, 2025 22:01
@kendallstrautman kendallstrautman mentioned this pull request Nov 24, 2025
kendallstrautman added a commit that referenced this pull request Nov 24, 2025
## Description

Version bump for fix #1399

## Documentation

Does this require changes to the WorkOS Docs? E.g. the [API
Reference](https://workos.com/docs/reference) or code snippets need
updates.

```
[ ] Yes
```

If yes, link a related docs PR and add a docs maintainer as a reviewer.
Their approval is required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Vault interfaces not exported from root index.d.ts

3 participants