Remove leading slash from UM functions #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulAsjes
approved these changes
Jul 11, 2024
Contributor
PaulAsjes
left a comment
There was a problem hiding this comment.
Good catch, can we make sure that the tests check for this specifically? We're ran into similar problems with leading slashes in other libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An issue comes up when calling the getMagicAuth function:
{
"message": "Cannot GET //user_management/magic_auth/magic_auth_XXXXXXXXXXXXXXXX",
"error": "Not Found"
}
The crux of the issue is that there's a double slash getting appended to the front of the route after the base URL. In looking at the base URL, it includes an ending slash '/' and the path for the API call also includes a leading slash so I believe this to be the cause of the discrepancy.