Make workos-php compatible with PHP 7.3 #263
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This package is listed as requiring PHP >=7.3, but it seems to use some syntax introduced in PHP 8, as well as a version of PHPUnit that requires PHP 8. This pull request makes the minimal changes necessary to use this package in PHP 7.3.
workos-php/composer.json
Line 13 in 17bb840
To test, I used the following
Dockerfile:Strictly speaking, it wasn't necessary to update the tests and the PHPUnit version in order to use this package as a dependency on PHP 7.3. However, I wanted to run the tests to ensure that everything still worked.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.