Fix small bug in DirectorySync #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
PR Summary
Fixed a critical bug in DirectorySync's listGroups method and corrected documentation typos in multiple files.
- Fixed incorrect variable usage in
lib/DirectorySync.phpwhere$groupwas wrongly used instead of$userparameter, which would cause silent failures in group filtering - Corrected docstring typos in
lib/UserManagement.phpandlib/SSO.phpwhere 'DDomain' was fixed to 'Domain' in parameter descriptions
3 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
gcarvelli
commented
Jun 24, 2025
| $params["directory"] = $directory; | ||
| } | ||
| if ($user) { | ||
| $params["user"] = $group; |
Contributor
Author
There was a problem hiding this comment.
$group is undefined in this scope, this never could have worked.
mattgd
approved these changes
Jun 24, 2025
Contributor
mattgd
left a comment
There was a problem hiding this comment.
Thanks to you and Claude for this 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug and a few typos in PHPDocs.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.