Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Safeguard remove cap from collisions with roles #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schlessera merged 6 commits into from
May 6, 2025
Merged

Safeguard remove cap from collisions with roles #530

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c21ba54
Issue #98 - Added error message when we try to remove capability same…
BhargavBhandari90 Apr 5, 2025
cde87dd
Add behat test for remove-cap improvement
BhargavBhandari90 Apr 9, 2025
6c0b7f6
Improve behat test
BhargavBhandari90 Apr 9, 2025
84f3aa4
Fix behat test failing
BhargavBhandari90 Apr 9, 2025
6ecf307
Provided flag to remove role forcefully
BhargavBhandari90 May 1, 2025
19aa208
Adapt error message
schlessera May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add behat test for remove-cap improvement
  • Loading branch information
@BhargavBhandari90
BhargavBhandari90 committed Apr 9, 2025
commit cde87dde66908de7d178c97c52fce5d459bc39ee
20 changes: 20 additions & 0 deletions features/user.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,26 @@ Feature: Manage WordPress users
administrator
"""

Scenario: Show error when trying to remove capability same as role
Given a WP install

When I run `wp user create testuser2 [email protected] --first_name=test --last_name=user --role=contributor --porcelain`
Then STDOUT should be a number
And save STDOUT as {USER_ID}

When I run `wp user list-caps {USER_ID}`
Then STDOUT should contain:
"""
contributor
"""

When I run `wp user remove-cap {USER_ID}` contributor
Then the return code should be 1
And STDERR should be:
"""
Error: There is a role similar to 'contributor' capability. Use `wp user remove-role` instead.
"""

Scenario: Managing user capabilities
Given a WP install

Expand Down