Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Include any non default hook information in CompositeCommand #5921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielbachhuber merged 10 commits into from
Apr 27, 2024
Merged

Include any non default hook information in CompositeCommand #5921

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c45c422
Include any non default hook information in CompositeCommand
mrsdizzie Mar 20, 2024
f62b2d8
Merge branch 'wp-cli:main' into main
mrsdizzie Apr 26, 2024
497ec5a
Use util helper for hook descriptions
mrsdizzie Apr 26, 2024
a04d6fa
Update php/WP_CLI/Dispatcher/CompositeCommand.php
mrsdizzie Apr 26, 2024
65aac15
Add behat tests
mrsdizzie Apr 26, 2024
9f57e82
Specify number of columns in output
mrsdizzie Apr 26, 2024
67b101f
Apply suggestions from code review
mrsdizzie Apr 26, 2024
05ea4ec
Tweak language and distinguish between root commands and subcommands
danielbachhuber Apr 27, 2024
bbc0218
`'after_wp_load'` is the standard hook, so don't need to mention it
danielbachhuber Apr 27, 2024
19615c4
Use `When I run` when no errors are expected
danielbachhuber Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Pascal Birchler <[email protected]>
  • Loading branch information
@mrsdizzie @swissspidy
mrsdizzie and swissspidy authored Apr 26, 2024
commit 67b101fe23b6943aad34892993bba339b418713c
1 change: 1 addition & 0 deletions php/WP_CLI/Dispatcher/CompositeCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ public function get_shortdesc() {
public function get_hook() {
return $this->hook;
}

/**
Comment thread
mrsdizzie marked this conversation as resolved.
* Set the short description for this composite command.
*
Expand Down
1 change: 0 additions & 1 deletion php/utils.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1873,7 +1873,6 @@ function has_stdin() {
*
* @return string|null
*/

function get_hook_description( $hook ) {
Copy link
Copy Markdown
Member

@swissspidy swissspidy Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this just be a private method on the Help_Command class?

Copy link
Copy Markdown
Member Author

@mrsdizzie mrsdizzie Apr 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this needs to be a public util function because the handbook project doesn't use the output of wp help and needs similar code added there as well in order to have consistency. Was going to do a PR for that one next after this is added.

$events = [
'find_command_to_run_pre' => 'just before WP-CLI finds the command to run.',
Expand Down