Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refine pipeline extension lifecycle and remove listr2 coupling #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Nov 12, 2025
Merged

Refine pipeline extension lifecycle and remove listr2 coupling #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
413ff8e
Task 59: Quickstart readiness fidelity
pipewrk Nov 11, 2025
0b204dc
Default init template dependencies to latest
pipewrk Nov 11, 2025
e024fa0
Merge pull request #368 from theGeekist/review-critical-create-genera…
pipewrk Nov 11, 2025
879b155
Task 60: Harden tsx runtime readiness
pipewrk Nov 11, 2025
258283a
Merge pull request #369 from theGeekist/review-critical-create-genera…
pipewrk Nov 11, 2025
6fd78c4
Add PHP printer path readiness helper
pipewrk Nov 11, 2025
20b4b5f
Task 61b: Audit PHP driver tarball assets
pipewrk Nov 11, 2025
7ec2e2d
better typecheck timing in pre commit
pipewrk Nov 11, 2025
52a2af4
Merge pull request #370 from theGeekist/review-task-61-implementation…
pipewrk Nov 11, 2025
4e6a0ee
Add CLI codemod ingestion helper coverage
pipewrk Nov 11, 2025
3edee33
Task 62a: probe composer autoload metadata
pipewrk Nov 11, 2025
71c21a3
Task 62b: ship CLI composer fallback
pipewrk Nov 11, 2025
5f9d458
chore: fix lint
pipewrk Nov 11, 2025
892f0e4
Merge pull request #372 from theGeekist/review-task-62-implementation…
pipewrk Nov 11, 2025
658dac9
better typecheck timing in pre commit
pipewrk Nov 11, 2025
1d899ce
Add PHP printer path readiness helper
pipewrk Nov 11, 2025
d2912ea
Task 61b: Audit PHP driver tarball assets
pipewrk Nov 11, 2025
a06eecd
Task 62a: probe composer autoload metadata
pipewrk Nov 11, 2025
f199cce
Task 62b: ship CLI composer fallback
pipewrk Nov 11, 2025
38fffe8
chore: fix lint
pipewrk Nov 11, 2025
567c0ab
fix: P0 and P1 bug. integrated the Phase 9 way
pipewrk Nov 11, 2025
948f46d
Merge branch 'main' into review-php-json-ast-codemod-plan-document
pipewrk Nov 11, 2025
1598b7c
fix: P0 and P1 bug. integrated the Phase 9 way
pipewrk Nov 11, 2025
1632565
Propagated driver script path overrides to codemod ingestion
pipewrk Nov 12, 2025
47ee3e4
fixed surfaced p2
pipewrk Nov 12, 2025
e93cbd1
Merge pull request #371 from theGeekist/review-php-json-ast-codemod-p…
pipewrk Nov 12, 2025
068cbb6
Refine pipeline extension lifecycle and remove listr2 coupling
pipewrk Nov 12, 2025
2858faf
Merge remote-tracking branch 'origin/main' into review-pr-for-pipelin…
pipewrk Nov 12, 2025
f2222df
fixed: async handling
pipewrk Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions docs/.vitepress/cli-create-init-doctor.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,14 @@ Any additional hooks (e.g., pnpm support) should be noted here as they are disco

## Readiness unit inventory (Task 53)

| Readiness unit | Current location | Behaviour today | Gaps / brittleness | Proposed DXIRv1 owner |
| ------------------- | ------------------------------------------------ | -------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------- | ----------------------------------------------------------------------------- |
| `php-runtime` | Doctor command (PHP checks inline) | Invokes PHP binaries via `execFile` and reports pass/warn/fail directly. | Hard-coded command wiring; no reuse by create/init/generate. | Dedicated helper under `dx/readiness/phpRuntime`. |
| `composer` | Doctor + init installers | Composer install only runs during create/init; doctor just confirms autoload presence. | No detection/skip logic; failing installs throw generic `DeveloperError`. | Helper that detects composer availability and installs autoload when missing. |
| `php-driver` | Doctor (composer autoload) & runtime assumptions | Relies on `@wpkernel/php-driver` being present in node_modules/vendor without packaging awareness. | Published CLI missed PHP driver assets; no detection before generate/apply. | Helper that validates bundled assets and backfills via composer if missing. |
| `tsx-runtime` | Implicit expectation in CLI runtime | No installer; commands assume `tsx` is in devDependencies. | Scaffolded projects fail immediately because tsx is absent. | Helper that installs or prompts for tsx during prepare/execute. |
| `git` | Workspace utilities | `ensureCleanDirectory` and `isGitRepository` throw WPKernel errors on failure. | Checks run in different places, no central reporting or confirm step. | Helper that consolidates git detection and repository initialisation. |
| `workspace-hygiene` | Workspace utilities + doctor | Cleanliness checks exist but are triggered ad-hoc. | Duplicate logging formats and inconsistent skip flags (`--yes`). | Helper that standardises detection and confirm messaging. |
| Readiness unit | Current location | Behaviour today | Gaps / brittleness | Proposed DXIRv1 owner |
| ------------------- | ------------------------------------------------ | -------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------- |
| `php-runtime` | Doctor command (PHP checks inline) | Invokes PHP binaries via `execFile` and reports pass/warn/fail directly. | Hard-coded command wiring; no reuse by create/init/generate. | Dedicated helper under `dx/readiness/phpRuntime`. |
| `composer` | Doctor + init installers | Composer install only runs during create/init; doctor just confirms autoload presence. | No detection/skip logic; failing installs throw generic `DeveloperError`. | Helper that validates plugin autoload metadata, installs dependencies when missing, and falls back to the CLI-bundled vendor cache. |
| `php-driver` | Doctor (composer autoload) & runtime assumptions | Relies on `@wpkernel/php-driver` being present in node_modules/vendor without packaging awareness. | Published CLI missed PHP driver assets; no detection before generate/apply. | Helper that validates bundled assets and backfills via composer if missing. |
| `tsx-runtime` | Implicit expectation in CLI runtime | No installer; commands assume `tsx` is in devDependencies. | Scaffolded projects fail immediately because tsx is absent. | Helper that installs or prompts for tsx during prepare/execute. |
| `git` | Workspace utilities | `ensureCleanDirectory` and `isGitRepository` throw WPKernel errors on failure. | Checks run in different places, no central reporting or confirm step. | Helper that consolidates git detection and repository initialisation. |
| `workspace-hygiene` | Workspace utilities + doctor | Cleanliness checks exist but are triggered ad-hoc. | Duplicate logging formats and inconsistent skip flags (`--yes`). | Helper that standardises detection and confirm messaging. |

## Published artifact validation

Expand All @@ -84,12 +84,12 @@ All downstream integration and validation tasks must exercise the packed CLI (`p

### Subtask ledger

| Subtask | Scope | Status | Notes |
| ------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| 55a | Extend `createInitCommandRuntime` to build a DX context and readiness registry before invoking the init workflow. Touches `packages/cli/src/commands/init/command-runtime.ts` and `packages/cli/src/dx/readiness/*` to expose a `runReadiness` seam for commands. | ✅ Complete | Registry builder + DX context now surface `readiness.run`/`plan` with default helper order for downstream commands. |
| 55b | Route `create`/`init` through the readiness plan, mapping flags such as `--skip-install`/`--yes` onto helper configuration. Update command orchestration in `packages/cli/src/commands/create.ts` and `packages/cli/src/commands/init.ts`, adding regression tests under `packages/cli/src/commands/__tests__`. | ✅ Complete | Commands now execute readiness plans after scaffolding, honouring skip/install flags and surfacing hygiene overrides while keeping existing summaries and exit codes intact. |
| 55c | Wrap `doctor` health checks with readiness helpers so reporter output stays consistent while leveraging the shared registry. Work centers on `packages/cli/src/commands/doctor.ts` with coverage in `packages/cli/src/commands/__tests__/doctor*.test.ts`. | ✅ Complete | Doctor now funnels composer, workspace, and PHP diagnostics through the readiness registry while preserving config/composer mapping summaries. |
| 55d | Add targeted readiness entry points for `generate`/`apply` flows, triggering php-driver and tsx helpers on demand. Update command modules in `packages/cli/src/commands/generate.ts` and `packages/cli/src/commands/apply.ts`, plus integration fixtures in `packages/cli/tests`. | ✅ Complete | Commands now invoke readiness plans to ensure PHP driver assets and tsx are available before execution, with integration suites covering the new checks. |
| Subtask | Scope | Status | Notes |
| ------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| 55a | Extend `createInitCommandRuntime` to build a DX context and readiness registry before invoking the init workflow. Touches `packages/cli/src/commands/init/command-runtime.ts` and `packages/cli/src/dx/readiness/*` to expose a `runReadiness` seam for commands. | ✅ Complete | Registry builder + DX context now surface `readiness.run`/`plan` with default helper order for downstream commands. |
| 55b | Route `create`/`init` through the readiness plan, mapping flags such as `--skip-install`/`--yes` onto helper configuration. Update command orchestration in `packages/cli/src/commands/create.ts` and `packages/cli/src/commands/init.ts`, adding regression tests under `packages/cli/src/commands/__tests__`. | ✅ Complete | Commands now execute readiness plans after scaffolding, honouring skip/install flags and surfacing hygiene overrides while keeping existing summaries and exit codes intact. |
| 55c | Wrap `doctor` health checks with readiness helpers so reporter output stays consistent while leveraging the shared registry. Work centers on `packages/cli/src/commands/doctor.ts` with coverage in `packages/cli/src/commands/__tests__/doctor*.test.ts`. | ✅ Complete | Doctor now funnels composer, workspace, and PHP diagnostics through the readiness registry while preserving config/composer mapping summaries. |
| 55d | Add targeted readiness entry points for `generate`/`apply` flows, triggering php-driver and tsx helpers on demand. Update command modules in `packages/cli/src/commands/generate.ts` and `packages/cli/src/commands/apply.ts`, plus integration fixtures in `packages/cli/tests`. | ✅ Complete | Commands now invoke readiness plans to ensure Composer autoload metadata (falling back to the CLI vendor cache), PHP driver assets, and tsx are available before execution, with integration suites covering the new checks. |

## Task 56 – Reporter & logging alignment

Expand Down
Loading