Phase 9: unblock readiness factory typing #375
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
wp-kernel/packages/cli/src/commands/create.ts
Lines 140 to 147 in 92c110b
wpk create ignores readiness helpers provided via config
readiness.helpers factories from the project config are passed into runCommandReadiness for apply and generate, but the create command never forwards them. The call to executeInitCommand (lines shown) constructs readiness hooks, yet the runtime options it supplies omit config.readiness?.helpers, so createInitCommandRuntime builds a registry with only the built‑ins. A project defining custom readiness helpers in its config will therefore never see them executed when running wpk create. To keep command behaviour consistent with the new configuration API, propagate helperFactories from the loaded config when preparing the create command’s readiness phase.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Testing
Codex Task