Fix swapNames in session-three files #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated signature to match call on line 69 - Removed unnecessary `malloc` as we're only changing pointers - Removed call to `free` as `malloc` was removed
Added calls to `free` for `info.password` allocated by `gen_password`
- Updated signature to match call on line 71 - Removed unnecessary `malloc` as we're only changing pointers
|
Just merged this - thanks for pointing this out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
swapNamesin pointers-struct.c and enums.c have an incorrect function signature. If we're swapping what username and password point to as it seems to be the case when calling theswapNamesfunction frommain, both parameters should be of typechar **and notchar *.This change also fixes the ELF generated which seems to be swapping just the first character of an address instead of swapping the strings. In reality it only works as both argv[2] and argv[3] are very close and we're just changing the last byte of the address. There could be cases where the addresses of argv[2] and argv[3] have the last two bytes which are different
Also removed unnecessary
mallocwhich was also not beingfreed.Should this pull request be accepted, the relevant binaries would also need to be updated