Fix wxTextEntryDialog from being resizable to 0, 0 (and other tweaks) #25784
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadz
reviewed
Sep 9, 2025
| @@ -81,7 +81,8 @@ bool wxTextEntryDialog::Create(wxWindow *parent, | |||
| return false; | |||
| } | |||
|
|
|||
| SetMinSize( sz ); | |||
| if (sz.IsFullySpecified()) | |||
| topsizer->Add(buttonSizer, wxSizerFlags().Expand().DoubleBorder()); | ||
| } | ||
|
|
||
| SetSizer( topsizer ); | ||
|
|
||
| topsizer->Fit( this ); | ||
| if (sz.IsFullySpecified()) |
There was a problem hiding this comment.
This also seems suspicious, why should we do this for this particular dialog and not any other ones?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see a way to force a max height (only size, which we don't want since the width should always be resizable). However, for a single-line dialog I fixed it so that the button row remains at the bottom of the dialog when resized. That seems much nicer looking then before.
#25739