Reduce QToEuler gimbal lock snapping#266
Merged
Merged
Conversation
Member
|
Does this affect original QToEuler? If so we might wanna lock in whatever behavior it has not to break legacy mods. If not then LGTM |
Contributor
Author
|
It does affect QToEuler, I can retain the legacy behavior if you think that's the best approach! |
|
Would it be at all worth it to have a parameter to define a threshold manually? |
Contributor
Author
|
Probably not no. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decrease threshold for gimbal lock handling to reduce rotation snapping.
New threshold might be too tight, but no issues were found in testing.