This repository was archived by the owner on May 1, 2024. It is now read-only.
Implement SetSemanticFocus and Announce APIs #1727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| AutomationNotificationKind.ActionAborted, | ||
| AutomationNotificationProcessing.ImportantMostRecent, | ||
| text, | ||
| "270FA098-C644-40A2-A0BE-A9BEA1222A1E"); |
There was a problem hiding this comment.
could you move it to constants with an appropriate name?
pictos
reviewed
Nov 21, 2021
There was a problem hiding this comment.
@rachelkang Thanks for this❣️ can you take a look on my suggestion on for loop? I'll keep it as a comment to not block the merge (:
| public static partial class SemanticExtensions | ||
| { | ||
| static void PlatformSetSemanticFocus(this VisualElement element) => | ||
| throw new NotSupportedException($"The current platform '{Device.RuntimePlatform}' does not support Xamarin.CommunityToolkit.SemanticExtensions"); |
There was a problem hiding this comment.
Note for the future me. Create an exception helper class like essentials
| // you really shouldn't be using the announce API | ||
| static AutomationPeer? FindAutomationPeer(DependencyObject depObj) | ||
| { | ||
| if (depObj != null) |
| { | ||
| if (depObj != null) | ||
| { | ||
| for (var i = 0; i < VisualTreeHelper.GetChildrenCount(depObj); i++) |
There was a problem hiding this comment.
Can we cache the VisualTreeHelper.GetChildrenCount() value? (If it doesn't change)
pictos
approved these changes
Nov 24, 2021
jfversluis
approved these changes
Dec 16, 2021
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Bug
Implements SetSemanticFocus and Announce APIs for screen reader accessibility
Future TODO: Implement Support SetSemanticFocus on Windows
Issues Fixed
Behavioral Changes
SetSemanticFocuscan be leveraged to direct the screen reader focus to a specific controlAnnouncecan be leveraged to instruct the screen reader to announce specific textPR Checklist
approved