Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

CameraView: fixed leak on UWP not cleaning up MediaCapture object for preview #1951

Merged
merged 2 commits into from
Apr 20, 2023
Merged

CameraView: fixed leak on UWP not cleaning up MediaCapture object for preview #1951

merged 2 commits into from
Apr 20, 2023

Conversation

MFinkBK
Copy link
Contributor

@MFinkBK MFinkBK commented Feb 23, 2023

Description of Bug

This fixes the bug from issue #1950 by correctly setting isPreviewing so that at clean-up time, the MediaCapture object is cleaned up properly.

Issues Fixed

Behavioral Changes

The CameraView on UWP doesn't leak normal and GPU memory anymore.

PR Checklist

  • Has a linked Issue, and the Issue has been approved
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@MFinkBK
Copy link
Contributor Author

MFinkBK commented Apr 12, 2023

@jfversluis @pictos Hey there! How can we progress with this PR? I have some more changes on my fork of this repository where all users of CameraView would benefit from. Thanks!

bijington
bijington approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@bijington bijington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @MFinkBK

@bijington
Copy link
Contributor

@jfversluis @pictos Hey there! How can we progress with this PR? I have some more changes on my fork of this repository where all users of CameraView would benefit from. Thanks!

Thanks for this fix. Out of interest what are the other changes? Are they just bug fixes or are they enhancements? This repo is frozen in terms of new development but we are more than happy for bugs to be fixed :)

@bijington bijington merged commit 6167ed4 into xamarin:main Apr 20, 2023
@MFinkBK MFinkBK deleted the cameraview-uwp-fix-preview-leak branch April 21, 2023 06:59
@MFinkBK
Copy link
Contributor Author

MFinkBK commented Apr 21, 2023

@bijington You can take a look at our forked repository here: https://github.com/MFinkBK/XamarinCommunityToolkit/
I will open some more issues here and will make more PRs out of our fork.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bijington bijington bijington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] CameraView leaks preview MediaCapture on UWP
3 participants
@MFinkBK @bijington @pictos