Bug/692 badge view #705
Bug/692 badge view #705
Conversation
|
|
src/CommunityToolkit/Xamarin.CommunityToolkit/Views/BadgeView/BadgeView.shared.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit/Xamarin.CommunityToolkit/Views/BadgeView/BadgeView.shared.cs
Outdated
Show resolved
Hide resolved
…BadgeView.shared.cs
…BadgeView.shared.cs
src/CommunityToolkit/Xamarin.CommunityToolkit/Views/BadgeView/BadgeView.shared.cs
Show resolved
Hide resolved
…BadgeView.shared.cs
| @@ -157,6 +159,25 @@ public FontAttributes FontAttributes | |||
| set => SetValue(FontAttributesProperty, value); | |||
| } | |||
|
|
|||
| static void IsRoundedChanged(BindableObject bindable, object oldvalue, object newvalue) => | |||
There was a problem hiding this comment.
I suggest to follow the same order creation of BindableProperty, getter/setter, property changed event:
BindableProperty.Create
...
public bool IsRounded
...
static void IsRoundedChanged(BindableObject bindable, object oldvalue, object newvalue) =>
src/CommunityToolkit/Xamarin.CommunityToolkit/Views/BadgeView/BadgeView.shared.cs
Outdated
Show resolved
Hide resolved
|
@jmmortega are you able to still answer the questions and/or make the requested changes? If not, no problem! Just let us know so we can take over :) Thanks! |
|
@jfversluis Yep!. Sorry! This weekend complete all your requests! |
|
@jmmortega Could you please resolve the conflict ? |
|
|
||
| public static BindableProperty IsRoundedProperty = | ||
| BindableProperty.Create(nameof(IsRounded), typeof(bool), typeof(BadgeView), true, | ||
| propertyChanged:IsRoundedChanged); |
There was a problem hiding this comment.
| public static BindableProperty IsRoundedProperty = | |
| BindableProperty.Create(nameof(IsRounded), typeof(bool), typeof(BadgeView), true, | |
| propertyChanged:IsRoundedChanged); | |
| /// <summary> | |
| /// Backing BindableProperty for the <see cref="IsRounded"/> property. | |
| /// </summary> | |
| public static BindableProperty IsRoundedProperty = | |
| BindableProperty.Create(nameof(IsRounded), typeof(bool), typeof(BadgeView), true, | |
| propertyChanged:IsRoundedChanged); |
|
Hey @jmmortega sorry for getting back to this so late... Are you still interested in fixing this? :) I think it makes sense to make the badges round, I'm not sure on the approach here though... Could we change it to open up the corner radius to people? We will make it round by default, but if they want anything different they can just use the corner radius to do something else? If you're not interested anymore for whatever reason, I totally understand, just please let us know so we or someone else can take it. Thanks! |
|
Trying to draw some attention to this pr, I guess it needs a re-target to develop. |
|
@Cfun1 thank you :) Yes please @jmmortega could you please retarget this PR to develop branch? |
|
@jmmortega Could you please resolve the merge conflicts? Thanks! |
|
Really looking forward to this getting implemented! |
|
Any news here? Could somebody resolve the conflicts and merge?! |
|
Closing PR as it has been abandoned. If anybody is interested in taking over this PR we are more than happy to re-open it! |
Description of Change
Improve round BadgeView. (A better approach maybe is measure Label text to get size an create round badge from here)
Bugs Fixed
#692 and #641
API Changes
Added:
Changed:
Behavioral Changes
Have a new property inside of BadgeView that for default is True so, in this case devs must be check if BadgeView adapt to design.
PR Checklist