Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

Make the BadgeView round #977

Closed
wants to merge 3 commits into from
Closed

Conversation

Cfun1
Copy link
Contributor

@Cfun1 Cfun1 commented Feb 25, 2021

Description of Change

Make the BadgeView round by replacing Frame by Ellipse

Bugs Fixed

API Changes

BackgroundColor has conflict upon type change is renamed to BadgeBackgroundColor and set as deprecated.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard

@jfversluis
Copy link
Member

We also have open #705 is this additional or a different way or?

@Cfun1
Copy link
Contributor Author

Cfun1 commented Feb 25, 2021

We also have open #705 is this additional or a different way or?

My bad I didn't check if there was a pr already and forgot about that one, not a problem because I went with a completly different approach by replacing the Frame with Ellipse I noticed it given nice rounded (circle) shape without overhead of calculations.

Now I noticed in the other pr discussion devs may need a CornerRadius property could you please explain the intend of use? @jfversluis would love to hear your thoughts about this approach.

@jfversluis
Copy link
Member

If you look at some code you changed, at some point there is the corner radius being set for iOS and Android, basically just allow that to be set by a property on the BadgeView :)

@jfversluis jfversluis closed this Feb 25, 2021
@Cfun1
Copy link
Contributor Author

Cfun1 commented Feb 25, 2021

Got it ! devs may want their badge view not to be round 👍🏻

@Cfun1 Cfun1 deleted the Round-BadgeView branch March 6, 2021 12:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants