This repository was archived by the owner on Jan 13, 2025. It is now read-only.
Improve Kotlin Binding Support #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why, but the later the version of Kotlin the app uses, more methods are not found.
mattleibow
commented
Oct 3, 2019
| @@ -1,6 +1,6 @@ | |||
| plugins { | |||
| id 'java' | |||
| id 'org.jetbrains.kotlin.jvm' version '1.3.41' | |||
| id 'org.jetbrains.kotlin.jvm' version '1.3.0' | |||
There was a problem hiding this comment.
Just a note about the version numbers: As I update the version to the later ones, it struggles to find various members. So, I just dropped it all the way down. Not sure what is happening here, but it works now...
mattleibow
commented
Oct 3, 2019
| @@ -20,6 +20,9 @@ class ProcessXmlCommand : CliktCommand(name = "KotlinBindingSupport") { | |||
| val outputFile: File? by option("-o", "--output", help = "path to the output transform file") | |||
| .file(fileOkay = true, folderOkay = false) | |||
|
|
|||
| val ignoreFile: File? by option("-i", "--ignore", help = "path to the ignore file") | |||
| .file(fileOkay = true, folderOkay = false) | |||
There was a problem hiding this comment.
I don't actually thing this is needed anymore since it is working properly with a lower Kotlin version, but just in case.
mattleibow
commented
Oct 3, 2019
| @@ -196,13 +203,13 @@ class Processor(xmlFile: File, jarFiles: List<File>, outputFile: File?) { | |||
|
|
|||
| // remove the members that are not meant to be used | |||
| processMembers(xclass, "constructor") { | |||
| shouldRemoveMember(it, jclass.declaredConstructors) | |||
| shouldRemoveMember(it, jclass.declaredConstructors + jclass.constructors) | |||
There was a problem hiding this comment.
This is still a required change because several members are not found for some reason. It works now, so...
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Redth
approved these changes
Oct 3, 2019
mattleibow
added a commit
that referenced
this pull request
Oct 4, 2019
This reverts commit 238ae5c.
Merged
mattleibow
added a commit
that referenced
this pull request
Oct 4, 2019
This reverts commit e3c55a9.
|
This was a failure, re-doing it: #689 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.