Add handling of cftime bounds #441
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mathause any thoughts on this one? (Calling on a familiar name :)) |
9ca3286 to
938e566
Compare
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #441 +/- ##
===========================================
- Coverage 86.40% 37.24% -49.16%
===========================================
Files 22 21 -1
Lines 3994 3936 -58
Branches 194 199 +5
===========================================
- Hits 3451 1466 -1985
- Misses 491 2271 +1780
- Partials 52 199 +147
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment this just adds a failing test that shows that add_bounds fails if the times are cftimes. I'm not sure what the best solution would be.