Change Parse method to accept io.Reader instead of []byte#14
Merged
Conversation
Accepting io.Reader is idiomatic Go for byte-stream consumption. Callers can now pass *os.File, http.Response.Body, strings.NewReader, etc. directly. Internally io.ReadAll buffers the bytes for goldmark, which is identical overhead to what callers did before with os.ReadFile.
48e4990 to
33beee6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change modifies the
Parser.Parse()method signature to accept anio.Readerinstead of a byte slice, improving flexibility and reducing memory overhead for large files.Key Changes
Parse(source []byte)toParse(r io.Reader)to accept any reader implementationio.ReadAll()call within Parse to convert the reader to bytes for processingexamples/parse,examples/flatten, andexamples/scaleto useos.Open()and pass file handles directly instead of reading entire files into memory withos.ReadFile()bytes.NewReader()when calling ParseresolveLinkedRecipe()to wrap file data withbytes.NewReader()when recursively parsing linked recipesBenefits
https://claude.ai/code/session_01U634BP9mJy46WX8oNtJHnr