Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@8ctopus
Copy link
Contributor

@8ctopus 8ctopus commented Feb 3, 2023

Add ignore exceptions based on class name.

For some reason, mocha tests don't work on my system. It could be that it's not 100% correct, so please be understanding.

@8ctopus 8ctopus changed the title Ignore exceptions based on class name feat: Ignore exceptions based on class name Feb 3, 2023
@zobo
Copy link
Contributor

zobo commented Feb 3, 2023

Hi!

Thanks for the PR. Exception "breakpoints" are a missing feature for some time, but due to the lack of proper UI support they were not yet implemented.

Interesting approach here, I will look at it more closely.

@8ctopus
Copy link
Contributor Author

8ctopus commented Feb 3, 2023

Thank you, I implemented it this way, because when running Laravel, I get tons of exceptions from within the templating engine, the cookie decryption engine and so forth... This change allows to remove the focus from what can safely be ignored.

@zobo
Copy link
Contributor

zobo commented Feb 3, 2023

I completely agree this is needed. I just want to be sure before adding new options to launch.json that can be hard to remove later if I decide to reimplement things differently.

@zobo
Copy link
Contributor

zobo commented Feb 3, 2023

Try running npm run lint

@8ctopus
Copy link
Contributor Author

8ctopus commented Feb 3, 2023

I ran the linter before implementing the test and didn't check afterwards. It's now fixed. All linter complaints are in parts I didn't touch.

@8ctopus
Copy link
Contributor Author

8ctopus commented Feb 7, 2023

Any thoughts?

@zobo
Copy link
Contributor

zobo commented Feb 10, 2023

Sorry about the delay, I was away. Will take a look at it again in the next days snd probably just merge.

@8ctopus
Copy link
Contributor Author

8ctopus commented Feb 12, 2023

Thank you for the update @zobo , I can't wait to use it.

@zobo
Copy link
Contributor

zobo commented Feb 12, 2023

I did some updates and fixes. Decided to rename the setting to ignoreExceptions since we already have ignore and skipFiles.

@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Merging #882 (fe283fe) into main (75c3e1d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
+ Coverage   67.57%   67.60%   +0.03%     
==========================================
  Files          12       12              
  Lines        1943     1945       +2     
  Branches      386      388       +2     
==========================================
+ Hits         1313     1315       +2     
  Misses        630      630              
Impacted Files Coverage Δ
src/phpDebug.ts 62.32% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@8ctopus
Copy link
Contributor Author

8ctopus commented Feb 13, 2023

Awesome, can't wait for the merge. Thank you for looking into it @zobo

@8ctopus
Copy link
Contributor Author

8ctopus commented Feb 23, 2023

@zobo When can we expect the merge?

@zobo zobo merged commit 120f688 into xdebug:main Feb 23, 2023
@zobo
Copy link
Contributor

zobo commented Feb 23, 2023

Wanted to find a better solution as new cases showed up, but can't get to it now, so I merged it now. Hope it helps. Will revisit and find a better solution.

@github-actions
Copy link

🎉 This PR is included in version 1.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@8ctopus
Copy link
Contributor Author

8ctopus commented Feb 23, 2023

Awesome thank you.

@8ctopus 8ctopus deleted the ignore-exceptions branch February 23, 2023 10:13
@zobo zobo mentioned this pull request Feb 24, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants