-
-
Notifications
You must be signed in to change notification settings - Fork 180
feat: Ignore exceptions based on class name #882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! Thanks for the PR. Exception "breakpoints" are a missing feature for some time, but due to the lack of proper UI support they were not yet implemented. Interesting approach here, I will look at it more closely. |
|
Thank you, I implemented it this way, because when running Laravel, I get tons of exceptions from within the templating engine, the cookie decryption engine and so forth... This change allows to remove the focus from what can safely be ignored. |
|
I completely agree this is needed. I just want to be sure before adding new options to |
|
Try running |
|
I ran the linter before implementing the test and didn't check afterwards. It's now fixed. All linter complaints are in parts I didn't touch. |
|
Any thoughts? |
|
Sorry about the delay, I was away. Will take a look at it again in the next days snd probably just merge. |
|
Thank you for the update @zobo , I can't wait to use it. |
|
I did some updates and fixes. Decided to rename the setting to |
Codecov Report
@@ Coverage Diff @@
## main #882 +/- ##
==========================================
+ Coverage 67.57% 67.60% +0.03%
==========================================
Files 12 12
Lines 1943 1945 +2
Branches 386 388 +2
==========================================
+ Hits 1313 1315 +2
Misses 630 630
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Awesome, can't wait for the merge. Thank you for looking into it @zobo |
|
@zobo When can we expect the merge? |
|
Wanted to find a better solution as new cases showed up, but can't get to it now, so I merged it now. Hope it helps. Will revisit and find a better solution. |
|
🎉 This PR is included in version 1.32.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Awesome thank you. |
Add ignore exceptions based on class name.
For some reason, mocha tests don't work on my system. It could be that it's not 100% correct, so please be understanding.