fix: Autohook silently failing issue #36#37
Merged
iamdaniele merged 6 commits intoxdevplatform:masterfrom Aug 5, 2020
sachushaji:autohook-issue-36
Merged
fix: Autohook silently failing issue #36#37iamdaniele merged 6 commits intoxdevplatform:masterfrom sachushaji:autohook-issue-36
iamdaniele merged 6 commits intoxdevplatform:masterfrom
sachushaji:autohook-issue-36
Conversation
|
|
iamdaniele
suggested changes
Aug 4, 2020
Contributor
iamdaniele
left a comment
There was a problem hiding this comment.
Thank you @sachushaji for the PR! ✨ I'm requesting a few changes before we can give it a #shipit and package.
Contributor
Author
|
Thanks @iamdaniele for the detailed review. I have made some changes. For the style issues, I think it would be great if we have a eslint config enforcing them so that we can see it right away from the code editor. |
iamdaniele
approved these changes
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
By default, ngrok tunnels without an authtoken will be terminated within a certain time period thereby failing silently the autohook after a few hours of uptime.
Solution
Result
This will solve the issue at which autohook silently stops listening to requests after certain hours of uptime. It will potentially solve issue #36