Assure that responses are resolved against the request base URI#249
Merged
ndw merged 1 commit intoxmlresolver:mainfrom May 19, 2025
Merged
Assure that responses are resolved against the request base URI#249ndw merged 1 commit intoxmlresolver:mainfrom
ndw merged 1 commit intoxmlresolver:mainfrom
Conversation
Fix xmlresolver#248 If we find ourselves trying to get a resource from a response and the URI isn’t absolute, and the base URI of the request also isn’t absolute, resolve the base URI of the request against the current working directory, then the relative URI against that. This is more likely to be correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #248
If we find ourselves trying to get a resource from a response and the URI isn’t absolute, and the base URI of the request also isn’t absolute, resolve the base URI of the request against the current working directory, then the relative URI against that. This is more likely to be correct.