Use unmasked URIs for RDDL; also, disable RDDL parsing by default#255
Merged
ndw merged 1 commit intoxmlresolver:mainfrom Jul 17, 2025
Merged
Use unmasked URIs for RDDL; also, disable RDDL parsing by default#255ndw merged 1 commit intoxmlresolver:mainfrom
ndw merged 1 commit intoxmlresolver:mainfrom
Conversation
Fix xmlresolver#253 By default jar: URIs are masked. If a resource is resolved locally, but the resolved location is in a jar: file, we return the original URI not the resolved URI. This is necessary because Java.net.URI doesn’t understand jar: URIs. (Oh, the irony.) Unfortunately, when the RDDL parser asked for the resolved URI, it got back the original too. So it would go attempt to parse the “real” location not the resolved resource. That’s been fixed. It now parses the unmasked URI, not the resolved URI. This is also the second bug (I think) caused by RDDL parsing. With some regret, I’m going to disable RDDL parsing by default. That means it will get used far, far less often, but since it’s not widely supported, that probably won’t have a huge impact. If you’re relying on it, remember to enable it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #253
By default jar: URIs are masked. If a resource is resolved locally, but the resolved location is in a jar: file, we return the original URI not the resolved URI. This is necessary because Java.net.URI doesn’t understand jar: URIs. (Oh, the irony.)
Unfortunately, when the RDDL parser asked for the resolved URI, it got back the original too. So it would go attempt to parse the “real” location not the resolved resource. That’s been fixed. It now parses the unmasked URI, not the resolved URI.
This is also the second bug (I think) caused by RDDL parsing. With some regret, I’m going to disable RDDL parsing by default. That means it will get used far, far less often, but since it’s not widely supported, that probably won’t have a huge impact. If you’re relying on it, remember to enable it.