This repository was archived by the owner on Nov 10, 2022. It is now read-only.
Support PHPCS standard phpcs.xml file name; supply default file and command args in ruleset#243
Merged
Conversation
westonruter
added a commit
to xwp/wp-customize-posts
that referenced
this pull request
Jun 8, 2017
westonruter
added a commit
to xwp/wp-customize-snapshots
that referenced
this pull request
Jul 5, 2017
…b#243 from branch update/phpcs xwp/wp-dev-lib@e52081e...bb1ae0b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for using standard PHPCS ruleset filenames
phpcs.xmlandphpcs.xml.dist, in addition to the custom previously-supportedphpcs.ruleset.xmlfile. When the standard filenames are used, they do not need to be supplied on the command line and will be automatically discovered by PHPCS by traversing the directory tree, just as ESLint and any number of other tools do.Additionally, in the past PHPCS in dev-lib would often need to get invoked like
phpcs -s --extensions=php .. These arguments are now unnecessary and are supplied by the default ruleset:-s: Show sniff codes in all reports--extensions=php: Limit reporting to PHP files..: By indicating a default file, PHPCS won't assume to look atSTDIN, allowing you to just invokephpcsinstead ofphpcs ..Fixes #231