Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't remove Content-Length header #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't remove Content-Length header #93

wants to merge 2 commits into from

Conversation

vjik
Copy link
Member

@vjik vjik commented May 8, 2025

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌

samdark
samdark approved these changes May 8, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented May 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (6e616f7) to head (02b5d37).

Additional details and impacted files 
@@             Coverage Diff              @@
##             master      #93      +/-   ##
============================================
- Coverage     98.72%   98.30%   -0.43%     
+ Complexity       77       76       -1     
============================================
  Files             4        4              
  Lines           236      236              
============================================
- Hits            233      232       -1     
- Misses            3        4       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik @samdark
Update CHANGELOG.md
02b5d37 
Co-authored-by: Alexander Makarov <[email protected]>
@xepozz
Copy link
Member

xepozz commented May 9, 2025

What's the reason?

@vjik
Copy link
Member Author

vjik commented May 9, 2025

What's the reason?

Case: in app we prepare response for HEAD request and manually added Content-Length header. Currently emiter remove this header, it's bug. This PR fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vjik @xepozz @samdark