Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update composer.json #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 17, 2022
Merged

Update composer.json #44

merged 3 commits into from
Dec 17, 2022

Conversation

lav45
Copy link
Contributor

@lav45 lav45 commented Dec 14, 2022

Fix version

Q A
Is bugfix? ✔️
New feature?
Breaks BC? ✔️
Fixed issues

@lav45
Copy link
Contributor Author

lav45 commented Dec 14, 2022

Composer выкачивает master ветку считая её как 2.0.* хотя она уже стала 3.0.*

@Swanty
Copy link
Contributor

Swanty commented Dec 14, 2022

yii2-symfonymailer README.md says // send all mails to a file by default. but the default is already false:
https://github.com/yiisoft/yii2/blob/2.0.47/framework/mail/BaseMailer.php#L79-L84

Comment is a little misleading and made me assume it's true by default and that I have to always add
'useFileTransport' => false, in my code or my mails would get saved to a file.
Is it possible to improve the comment? 🙏

@lav45
Copy link
Contributor Author

lav45 commented Dec 14, 2022

@Swanty I just replaced tabs with spaces
image

You can suggest your pull request and improve the description.
At the moment, it is more important to fix the pocket version as soon as possible so that users do not break backward compatibility.

@samdark

@Swanty
Copy link
Contributor

Swanty commented Dec 14, 2022

@lav45

Sorry, you're right, tried to piggyback the comment improvement with your pull request 😸

@samdark samdark merged commit fc36ff5 into yiisoft:master Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants