chore: remove unnecessary dependency on the Symfony mailer class #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the usage of the symfony mailer class. We did not use any of it's functionality.
We had a hard dependency on this class, but the code paths we used made it a very simple proxy. Since all usages were properly private there is no BC break.
First note the constructor of the class:
We only ever called this with 1 argument, setting the transport.
Then note the only other function, which we also only ever call with 1 argument:
Since we never set the bus variable, we can skip this class altogether and directly have the transport send the message.