feat: proxy transport events to events on the mailer component #52
Conversation
|
@samdark apologies for the rude ping. Could you have a look at this and tell me if you think this should be in:
I'd be happy to implement it in your preferred way. My opinion is that a mini library is the cleanest and with automated release like we have for the yii2-psr-log-source library the packaging / release overhead should actually be minimal. |
|
@SamMousa what's the plan on this one? |
|
Sorry for now answering in time. I've missed it somehow :( Separate package sounds OK but having it in this package is fine as well. |
|
If you want it in this package I think it's ready to be merged as is.
…On Mon, May 22, 2023 at 9:11 PM Alexander Makarov ***@***.***> wrote:
Sorry for now answering in time. I've missed it somehow :(
I think it should in this package.
—
Reply to this email directly, view it on GitHub
<#52 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEFRTOLVBKRSMA76ORV3K3XHO24XANCNFSM6AAAAAAU4UT25Y>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I think having it in this package makes sense since there are no additional use-cases that we were asked for yet. We can extract it later if needed. Would you please add a line for CHANGELOG? |
|
Also, it would be great to have |
|
Ready for merge @samdark |
|
👍 |
This implements a proxy for forwarding PSR-14 events to Yii2 components.
This is a WIP and I'd like discuss how the code works and how we should release it.
It is probably cleanest do put this in a separate library similar to https://github.com/yiisoft/yii2-psr-log-source