Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Drop support for php < 8.1 update dev dependencies #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 24, 2024
Merged

Drop support for php < 8.1 update dev dependencies #54

merged 13 commits into from
Jan 24, 2024

Conversation

SamMousa
Copy link
Contributor

@SamMousa SamMousa commented Feb 15, 2023 •
edited
Loading

Work in progress, blocked by some other PRs.

  • Add the logger proxy dependency as a dependency of this library after Feat dynamic logger yii2-psr-log-source#8 is merged and released -- it's a suggestion, which is good.
  • Add typed parameters and return types using union types
  • Improve phpdoc types
  • Enforce declare(strict_types=1)
  • Enforce classes to be final unless annotated with @extendable
  • Add phpstan
Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ✔️
Fixed issues #53

@samdark
Copy link
Member

samdark commented May 22, 2023

@SamMousa what's the plan on this one?

@SamMousa
Copy link
Contributor Author

SamMousa commented May 23, 2023 •
edited
Loading

Well it needs your approval, ie do we want to drop old php versions for this library?

If yes, i'll fix the last item in the checklist.

@samdark
Copy link
Member

samdark commented May 24, 2023

I'm not sure it's a good idea for the upcoming release. See yiisoft/yii2#19831

@SamMousa
Copy link
Contributor Author

I guess it's not up to me. I just think it's easier to get contributions by moving smaller packages to newer PHP versions.
People can always use older versions of this library if it works for them...

@samdark
Copy link
Member

samdark commented May 24, 2023

Yes. So this one is not for the next release but can be finished for the next one.

@mtangoo
Copy link
Contributor

mtangoo commented Jan 23, 2024

@SamMousa Now that PHP 7.x is long dead can you find time to finish this work so that it can be merged?
We need a release that supports 8.1 before moving our attention to higher PHP version and leave this version in maintenance mode with Yii2.2 spirit

@SamMousa SamMousa marked this pull request as ready for review January 23, 2024 08:53
@SamMousa
Copy link
Contributor Author

@mtangoo i think is almost good to go; check thoroughly please.

@SamMousa SamMousa changed the title [WIP] drop support for php < 8.1 update dev dependencies Drop support for php < 8.1 update dev dependencies Jan 23, 2024
@SamMousa SamMousa mentioned this pull request Jan 23, 2024
Closed
@mtangoo
Copy link
Contributor

mtangoo commented Jan 23, 2024

Great! I will go through as well as request a review before merging

@mtangoo mtangoo requested a review from a team January 23, 2024 09:23
@mtangoo mtangoo self-assigned this Jan 23, 2024
@mtangoo mtangoo merged commit 16da67d into yiisoft:master Jan 24, 2024
@mtangoo
Copy link
Contributor

mtangoo commented Jan 24, 2024

@SamMousa thanks for your time and efforts

@mtangoo mtangoo mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtangoo mtangoo mtangoo approved these changes

Assignees

@mtangoo mtangoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamMousa @samdark @mtangoo