Force undo manager to stop capture when pasting#19
Merged
Conversation
|
Hi, what is the state of this PR? Looking forward to have undo as a separate undoable event, but not quite sure if more work is required or if this solves it for JupyterLab. |
Contributor
Author
|
cc @dmonad what do you think of this solution? |
Member
|
Thank you for the fix @fcollonval! Sorry for the late merge. This is perfect. I'm going to publish a new release in a bit and open a PR to JupyterLab. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was raised in jupyterlab/jupyterlab#10928
The capture seems to be stopped before capturing the paste event. But the second stop capture statement is not working because I succeed to do undo's that removed characters typed after the paste change.