Open
Conversation
…and add registerTypeRef function for dynamic type registration
Author
|
@dmonad Any suggestion? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how type references are managed in the
ContentTypemodule, moving from an array-based approach to aMapfor better extensibility and safety. It also introduces a new utility function to allow dynamic registration of type references, and updates related exports accordingly.Refactoring and extensibility improvements:
typeRefsarray with aMapfor storing type reference IDs and their corresponding read functions, improving lookup efficiency and allowing dynamic registration.registerTypeReffunction to enable safe, dynamic registration of new type reference handlers, throwing an error if a duplicate ref is registered.readContentTypefunction to use the newMapstructure, with error handling for unknown type references.Export changes:
registerTypeReffunction fromsrc/index.jsto make it available for use elsewhere in the codebase.Cleanup:
typeRefsdeclaration and initialization.