mention plugin improvements #383
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snewcomer is attempting to deploy a commit to the dargo's projects Team on Vercel. A member of the Team first needs to authorize it. |
snewcomer
commented
Nov 6, 2024
| </span> | ||
|
|
||
| {showMenu && ( | ||
| <div role="listbox" aria-activedescendant={`mention-item-${highlightedIndex}`} className="mention-menu"> |
There was a problem hiding this comment.
should this use <Portal? Currently no positional information in this
There was a problem hiding this comment.
Actually we might need a new UI component for ListItem or the like.
Xusifob
reviewed
Feb 9, 2025
|
|
||
| interface MentionRenderProps extends PluginElementRenderProps { | ||
| initialMentions: string[]; | ||
| fetchMentions: (query: string) => Promise<string[]>; |
There was a problem hiding this comment.
Should we give the possibility to override this ? I might want to group mentions
JaumeRF
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mention component implementation
Fixes #114
Type of change
Please tick the relevant option.
Checklist: