[MSSQL] Add CLI Support and Allow multiple datasets in the same Database #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If attempting to load 2 datasets with different vector dimensions to the same database, a schema error will occur because the vector type is set to a specific dimension.
Using Euclidean distancefor all datasets was a relic from testing a development build.
The logging of Vector Insert time had a bug where python would throw a warning due to a formatting issue.
Since this project was developed, the API for the environs package has changed. Add a rule to pyproject.toml to use older versions of the package to not break the API.
Report the latencies for p50 and p95 and not just p99 in the serial search phase.
Add the ability to use EntraId authentication to login to SQL Server
The rest of the project uses the logging library to report info and errors. Switch the the changes on this branch to use the logging library for these purposes too.
Support EntraId
Owner
|
Closing as it needs to point to "vector" branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow MSSQL to use the Command Line Interface. Prior, SQL Server could only run with the use of the Web Interface.
Also, this patch drops the vector table type and corresponding Stored Procedure because there will be a schema error during the initialization phase as vector dimension is part of the schema, so running multiple datasets on the same database will require manually removing those parts otherwise.
Also, there was an issue with MemoryDB where an error was being thrown, even if we were not using MemoryDB.