Update rounded corners shader to only redraw the corners#1523
Open
0x041E wants to merge 1 commit into
Open
Conversation
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently the rounded corner shader draws the entire window and redraws the entire border. This patch makes the shader only redraw the rounded corners and keep the sides of the border intact which fixes #1519 where the shader overdrawn the border indicator in i3 window manager.
Comparison images highlighting in red what is redrawn:
Current behavior
with this patch
image of rounded borders and i3 border indicator working correctly using this patch
