TST: avoid mutating ndarray.shape attributes#597
Merged
neutrinoceros merged 1 commit intoJan 1, 2026
Conversation
4448cd0 to
5f0189f
Compare
Member
Author
cphyc
approved these changes
Oct 27, 2025
Member
cphyc
left a comment
There was a problem hiding this comment.
I went through the code and couldn't find any other place where the .shape attribute is modified directly. Thanks for fixing this :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is in anticipation of numpy/numpy#29536