Clarify event id vs. "at-least-once" delivery #694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came up again recently and it seems that the relation should be further elaborated. Random UUIDs are not suitable in certain situations (without intermediate persistence), even though they are guaranteed to be "unique from the perspective of the owning application", as required in rule 211.
Address review comments.
|
@tfrauenstein thank you for your comments! Do you think it is appropriate here to touch upon the two common strategies for publishers to ensure stable event id on retry, namely: intermediate persistence and consistent hashing? |
|
Yes, adding a 'design hint' might be helpful here, if it is not too long. |
Add design hint for stable eid on retry.
|
👍 |
|
@a1exsh sorry for the long delay and thanks for the contribution. Bad timing with Cyber Week and the prepared restructuring. Can you please resolve the conflict? Than I would also approve and merge the change. |
|
@tkrop @tfrauenstein please have another look |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up again recently and it seems that the relation should be further elaborated.
Random UUIDs are not suitable in certain situations (without intermediate persistence),
even though they are guaranteed to be "unique from the perspective of the owning application",
as required in rule 211.