Fix multiple empty lines at end of full-quote reply; add desktop app QUnit tests#5977
Draft
Fix multiple empty lines at end of full-quote reply; add desktop app QUnit tests#5977
Conversation
…ssue #2319) Co-authored-by: dominikklein <[email protected]>
Copilot
AI
changed the title
[WIP] Fix signature handling in old and new desktop apps
Fix: signature not applied when replying to own email with full quote enabled
Mar 2, 2026
Co-authored-by: dominikklein <[email protected]>
…issue #2319) Co-authored-by: dominikklein <[email protected]>
Copilot
AI
changed the title
Fix: signature not applied when replying to own email with full quote enabled
Remove dead Mar 2, 2026
signatureCheck and add QUnit coverage for blockquote signature scenarios
Co-authored-by: dominikklein <[email protected]>
Copilot
AI
changed the title
Remove dead
Fix multiple empty lines at end of full-quote reply; add desktop app QUnit tests
Mar 2, 2026
signatureCheck and add QUnit coverage for blockquote signature scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When composing a full-quote reply, the signature is prepended to the top (
signaturePosition = 'top'). The full-quote template always ends with<div><br></div>, sohtmlLastLineEmptyreturnsfalse— causingbody.append('<br><br>')to fire unconditionally and append two extra<br>elements after the blockquote instead of before a bottom-placed signature.Changes
email_reply.coffee— Movebody.append('<br><br>')inside theelse(bottom-placement) branch. It now only runs when the signature is appended to the bottom; top-placement already usesbody.prepend('<br><br>')for spacing and needs nothing added at the tail.html_utils.js— Add ahtmlLastLineEmptyQUnit test case for a full-quote body structure (outer body element whose last child is<div><br></div>) to document the precondition that drives the bug. Also addssignatureRemoveByHtmlcases covering signatures nested inside<blockquote>elements (the full-quote reply scenario from issue Replying to your own articles (agent perspective) does not generate signature on reply #2319).🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.