Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix multiple empty lines at end of full-quote reply; add desktop app QUnit tests#5977

Draft
Copilot wants to merge 5 commits intodevelopfrom
copilot/fix-signature-handling-issue
Draft

Fix multiple empty lines at end of full-quote reply; add desktop app QUnit tests#5977
Copilot wants to merge 5 commits intodevelopfrom
copilot/fix-signature-handling-issue

Conversation

Copy link

Copilot AI commented Mar 2, 2026

When composing a full-quote reply, the signature is prepended to the top (signaturePosition = 'top'). The full-quote template always ends with <div><br></div>, so htmlLastLineEmpty returns false — causing body.append('<br><br>') to fire unconditionally and append two extra <br> elements after the blockquote instead of before a bottom-placed signature.

Changes

  • email_reply.coffee — Move body.append('<br><br>') inside the else (bottom-placement) branch. It now only runs when the signature is appended to the bottom; top-placement already uses body.prepend('<br><br>') for spacing and needs nothing added at the tail.

    -      if !App.Utils.htmlLastLineEmpty(body)
    -        body.append('<br><br>')
           ...
           else if signaturePosition is 'top'
             body.prepend(signature)
             body.prepend('<br><br>')
           else
    +        if !App.Utils.htmlLastLineEmpty(body)
    +          body.append('<br><br>')
             body.append(signature)
  • html_utils.js — Add a htmlLastLineEmpty QUnit test case for a full-quote body structure (outer body element whose last child is <div><br></div>) to document the precondition that drives the bug. Also adds signatureRemoveByHtml cases covering signatures nested inside <blockquote> elements (the full-quote reply scenario from issue Replying to your own articles (agent perspective) does not generate signature on reply #2319).


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI changed the title [WIP] Fix signature handling in old and new desktop apps Fix: signature not applied when replying to own email with full quote enabled Mar 2, 2026
Copilot AI changed the title Fix: signature not applied when replying to own email with full quote enabled Remove dead signatureCheck and add QUnit coverage for blockquote signature scenarios Mar 2, 2026
Copilot AI changed the title Remove dead signatureCheck and add QUnit coverage for blockquote signature scenarios Fix multiple empty lines at end of full-quote reply; add desktop app QUnit tests Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants