fix tests for stand-alone example scripts #3605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
the min-deps test failure is caused by pytest-asyncio requiring a newer version of typing-extensions than our minimum supported version. That's fixed in #3606 |
normanrz
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since changing the layout of our standalone examples, we failed to update the tests, and so the examples are not currently getting tested. See https://github.com/zarr-developers/zarr-python/actions/runs/19712165663/job/56475393603#step:6:100 for a recent run where
test_examples.pydidn't collect any tests.This PR makes it a test failure if no example scripts are found, and corrects our example script discovery to find example scripts properly at test time.