Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Currently building
log-counterrequiresCGO_ENABLEDsince there is a dependency ongithub.com/coreos/go-systemd/v22/sdjournalwhich uses C-bindings to read system journal.This essentially produces a dynamically linked binary which is not portable across different versions of the same OS.
This is especially an issue if you want to build a binary which is portable across different versions of the same OS.
Static linking
This PR adds support for static-linking to the
log-counter- such that the log-counter calls out to thejournalctlbinary instead (which must be available in the host system) to read system journal entries.