Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix Kafka::TransactionManager#send_offsets_to_txn #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 12, 2020
Merged

fix Kafka::TransactionManager#send_offsets_to_txn #866

merged 3 commits into from
Nov 12, 2020

Conversation

stasCF
Copy link
Contributor

@stasCF stasCF commented Oct 21, 2020

@stasCF
Copy link
Contributor Author

stasCF commented Nov 10, 2020

Hey @dasch, can you give a little advice? I have a failing functional spec for 3 Kafka versions in CircleCI:

wurstmeister/kafka:2.11-0.11.0.3
wurstmeister/kafka:2.11-2.0.1
wurstmeister/kafka:2.12-2.4.0

The problem is I cannot reproduce this fail locally for any of these versions and it appears my code is not related with the failing spec. I run my specs in the same way as in CircleCI step.
What's the next steps should be?

@dasch
Copy link
Contributor

dasch commented Nov 10, 2020

@stasCF sorry about that – the functional specs are unfortunately a bit flaky. I've restarted them.

If someone was inclined to make them more robust I wouldn't at all mind ;)

dasch
dasch approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@dasch dasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Have you verified that this branch works in your staging or production setup?

lib/kafka/protocol/txn_offset_commit_response.rb

def self.decode(decoder)
_throttle_time_ms = decoder.int32
error_code = decoder.int16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get how this worked in the first place...

@stasCF
Copy link
Contributor Author

stasCF commented Nov 10, 2020

@dasch yes, we run our fork of ruby-kafka in production with this fix included for a couple of weeks and I can confirm it works as expected.

@dasch
Copy link
Contributor

dasch commented Nov 11, 2020

Awesome, thanks!

@dasch
Copy link
Contributor

dasch commented Nov 11, 2020

If you add a line to the changelog I'll go ahead and merge this.

@stasCF
Copy link
Contributor Author

stasCF commented Nov 12, 2020

@dasch done. thanks for your help!

@dasch dasch merged commit 1f72b1f into zendesk:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasch dasch dasch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stasCF @dasch