Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Modernize the package and finalize QA tooling #148

Merged
merged 19 commits into from
Apr 17, 2018
Merged

Modernize the package and finalize QA tooling #148

merged 19 commits into from
Apr 17, 2018

Conversation

weierophinney
Copy link
Member

This patch modernizes the package to follow guidelines as set in our maintainers repository.

In particular:

  • Moves documentation from /doc/ to /docs/.
  • Adds contribution and support docs.
  • Normalizes the composer.json structure.
  • Normalizes various package files (.gitignore, .gitattributes, etc.)
  • Ensures the Travis configuration uses up-to-date practices with regards to lowest/locked/latest strategy.

Additionally, this patch incorporates commits from #141 that accomplish the following:

  • Provides a polyfill for the PatternPluginManager to ensure it works with both v2 and v3 versions of zend-servicemanager, fixing an issue with PHP 7.2 compatibility.
  • Adds PHPUnit 7 as a potential target for running unit tests.
  • Provides a number of features around enabling extensions that act as cache backends.
  • Drops HHVM support.

weierophinney and others added 16 commits April 17, 2018 15:07
@weierophinney
Modernizes package
bdc0dbb 
Results of running `zf-maintainer rebase-doc-templates`. Updates the
package to follow current package guidelines with reference to
documentation location, support documents, `composer.json` structure,
etc.
@michalbundyra @weierophinney
Updated Travis CI configuration
0a5470f 
- added PHP 7.1 & PHP 7.2
- dropped HHVM
- removed building docs

Conflicts:
	.travis.yml
@michalbundyra @weierophinney
Updated PHPUnit configuration
428ed8d
@michalbundyra @weierophinney
Re-added ".ci" directory into .gitattributes
bcbee26 
Conflicts:
	.gitattributes
@michalbundyra @weierophinney
Updated Travis CI config - use installed version of pecl apcu
f606b31
@michalbundyra @weierophinney
Updated legacy dependencies
4705600
@michalbundyra @weierophinney
Run benchmarks on travis
74dd411
@michalbundyra @weierophinney
Updated Travis CI configuration
fa11927 
xcache is supported ONLY on PHP 5.6
@weierophinney
Move test autoloader to non-prefixed filename
32e1fa3
@michalbundyra @weierophinney
Travis CI config: added flag -f on 'pecl install'
ec78c31
@michalbundyra @weierophinney
Travis CI config: memcache supported only on PHP 5.6
6a91722
@michalbundyra @weierophinney
Travis CI config: enable php modules before installing packages
f1b68bb 
Conflicts:
	.travis.yml
@michalbundyra @weierophinney
🔥 Polyfill PatternPluginManager - to allow work with Zend SMv2 and v3
b5d9009 
Fixes issue with PHP 7.2 signature compatibility.

Conflicts:
	composer.json
	composer.lock
@michalbundyra @weierophinney
Travis CI config: updated apcu version on PHP 5.6
d386c12
@michalbundyra @weierophinney
Travis CI config: added pecl list and php -m
916126f
@michalbundyra @weierophinney
Allow PHPUnit 7
39c2dc4 
Conflicts:
	composer.json
	composer.lock
@weierophinney weierophinney mentioned this pull request Apr 17, 2018
Closed
@weierophinney
Copy link
Member Author

Pinging @webimpress ...

@weierophinney
Copy link
Member Author

Initial test runs that have actually completed (a number had segfaults and needed to be restarted) have been mostly successful, with one specific failure: the Cache\IntegrationTests\CachePoolTest::testHasItemReturnsFalseWhenDeferredItemIsExpired test case often fails. I suspect this is a timing issue primarily.

@weierophinney
Copy link
Member Author

I honestly think at this point the only way we'll get tests to run completely is to separate the adapters into their own repos, as @marc-mabe has planned for some time.

@weierophinney weierophinney merged commit d8da1fd into zendframework:develop Apr 17, 2018
weierophinney added a commit that referenced this pull request Apr 17, 2018
@weierophinney
Adds CHANGELOG entries for #148
e29acec
weierophinney added a commit that referenced this pull request Apr 17, 2018
@weierophinney
Merge branch 'feature/modernize-package' into develop
392f5f1 
Close #148
@weierophinney weierophinney deleted the feature/modernize-package branch April 17, 2018 21:24
@michalbundyra
Copy link
Member

@weierophinney

Pinging @webimpress ...

Sorry, I was not able to have a look before... LGTM 👍 😄

@thomasvargiu
Copy link
Contributor

thomasvargiu commented Apr 17, 2018 •
edited
Loading

@weierophinney About Cache\IntegrationTests\CachePoolTest::testHasItemReturnsFalseWhenDeferredItemIsExpired failed test, it's normal.

The Zend\Cache\Psr\CacheItemPoolAdapter adapter doesn't support driver deferred saves, so cache items are saved on destruct or on explicit commit() call.

I'm working on it and I'll open a PR to skip that test in a while.

@thomasvargiu
Copy link
Contributor

Open #149

This was referenced Apr 17, 2018
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weierophinney @michalbundyra @thomasvargiu