This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Issue #185 : replacing deprecated delete() calls with del() #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ppaulis Please see PR I've created to your branch: http://github.com/ppaulis/zend-cache/pull/1 |
|
@ppaulis , @webimpress please prepare and push these changes to release |
|
@webimpress i dont really think this is an enhancement but a bug which is blocking a lot nowadays? |
|
Not a bug: needs to indeed land in a new minor, since we are adding compatibility with a new tool, not fixing a bug here. |
Ocramius
suggested changes
Aug 26, 2019
|
As @boesing checked del() is available since 2.1.0 release. Ref:
and the latest version available on PECL is 2.2.3: There is no need to add any conflict. |
PHP 5.6: - 2.2.3 - 3.1.6 - 4.3.0 PHP 7.0-7.2: - 4.0.0 - 5.0.0 - 5.0.2
michalbundyra
added a commit
that referenced
this pull request
Aug 29, 2019
Issue #185 : replacing deprecated delete() calls with del()
michalbundyra
added a commit
that referenced
this pull request
Aug 29, 2019
michalbundyra
added a commit
that referenced
this pull request
Aug 29, 2019
|
Thanks, @ppaulis! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing Issue #185
Since redis extension 5.0.0, Deprecation errors are thrown on every Redis::delete() call.
Replacing the delete() calls with del() calls fixes these messages.