Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Travis: PHP-7 is no longer allowed to fail #74

Merged
merged 2 commits into from
May 12, 2016
Merged

Travis: PHP-7 is no longer allowed to fail #74

merged 2 commits into from
May 12, 2016

Conversation

marc-mabe
Copy link
Member

But something with the Memcached adapter seems to be wrong:

There were 4 failures:

1) ZendTest\Cache\Storage\Adapter\MemcachedTest::testCheckAndSetItem

Failed asserting that null is not null.

/home/travis/build/zendframework/zend-cache/test/Storage/Adapter/CommonAdapterTest.php:802

2) ZendTest\Cache\Storage\Adapter\MemcachedTest::testIncrementItemInitialValue

Failed asserting that false matches expected 5.

/home/travis/build/zendframework/zend-cache/test/Storage/Adapter/CommonAdapterTest.php:818

3) ZendTest\Cache\Storage\Adapter\MemcachedTest::testIncrementItemsResturnsKeyValuePairsOfWrittenItems

Failed asserting that Array &0 (

    'key1' => 20

) is identical to Array &0 (

    'key1' => 20

    'key2' => 10

).

/home/travis/build/zendframework/zend-cache/test/Storage/Adapter/CommonAdapterTest.php:842

4) ZendTest\Cache\Storage\Adapter\MemcachedTest::testDecrementItemInitialValue

Failed asserting that false matches expected -5.

@marc-mabe marc-mabe added the Test label Feb 12, 2016
@marc-mabe
Copy link
Member Author

Ok I just noticed that there is no release of the php memcached extension. There is only a not ready branch https://github.com/php-memcached-dev/php-memcached/tree/php7 but with a lot of test errors:

=====================================================================
TEST RESULT SUMMARY
---------------------------------------------------------------------
Exts skipped    :    0
Exts tested     :   26
---------------------------------------------------------------------

Number of tests :  125               114
Tests skipped   :   11 (  8.8%) --------
Tests warned    :    1 (  0.8%) (  0.9%)
Tests failed    :   17 ( 13.6%) ( 14.9%)
Expected fail   :    0 (  0.0%) (  0.0%)
Tests passed    :   96 ( 76.8%) ( 84.2%)
---------------------------------------------------------------------
Time taken      :   19 seconds
=====================================================================

=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
Memcached::casByKey() [tests/experimental/cas_bykey.phpt]
Memcached::cas() with strange key [tests/experimental/cas_invalid_key.phpt]
Memcached::deleteByKey() [tests/experimental/delete_bykey.phpt]
Memcached getDelayed() and fetch() with and without cas [tests/experimental/fetch.phpt]
Memcached::get() [tests/experimental/get.phpt]
Memcached::getByKey() with CAS [tests/experimental/get_bykey_cas.phpt]
Memcached::getDelayedByKey() [tests/experimental/getdelayed_bykey.phpt]
Memcached::getDelayedByKey() with CAS [tests/experimental/getdelayed_bykey_cas.phpt]
Memcached getDelayed non string keys [tests/experimental/getdelayed_nonstring_keys.phpt]
Memcached::getMulti() bad server [tests/experimental/getmulti_badserver.phpt]
Memcached::getMultiByKey() [tests/experimental/getmulti_bykey.phpt]
Memcached::getMulti() with empty array [tests/experimental/getmulti_empty.phpt]
Memcached::phpinfo() [tests/experimental/moduleinfo.phpt]
Compress with 0 factor and get [tests/experimental/setget_zero_factor.phpt]
Memcached::setMultiByKey() with bad serialize [tests/experimental/setmulti_badserialize.phpt]
Memcached::getStats() [tests/experimental/stats.phpt]
Memcached::getStats() with bad server [tests/experimental/stats_badserver.phpt]
=====================================================================

=====================================================================
WARNED TEST SUMMARY
---------------------------------------------------------------------
Memcached store, fetch & touch expired key [tests/expire.phpt] (warn: XFAIL section but test passes)
=====================================================================

It's kind of annoying that travis ships with that by default which makes it very difficult for us :(

@marc-mabe marc-mabe mentioned this pull request Feb 13, 2016
Closed
@Ocramius
Copy link
Member

@marc-mabe can we just disable those tests when the combo is PHP 7 + memcached, or would that be too risky? At least we'd be able to test php7 support for all other adapters...

@marc-mabe
Travis: disabled memcached tests on PHP-7
014cccf 
there is no memcached extension available for PHP-7
the version provided by travis is not yet ready and buggy
@marc-mabe
Copy link
Member Author

@Ocramius the memcached adapter is disabled now on PHP-7 by explicit TESTS_ZEND_CACHE_MEMCACHED_ENABLED=false

To make that work I also changed the is-enabled-check for all adapters to be consistent:

-        if (!getenv('TESTS_ZEND_CACHE_APC_ENABLED')) {
+        if (getenv('TESTS_ZEND_CACHE_APC_ENABLED') != 'true') {

@weierophinney weierophinney merged commit 014cccf into zendframework:master May 12, 2016
weierophinney added a commit that referenced this pull request May 12, 2016
@weierophinney
Merge pull request #74 from marc-mabe/travis_php7
d78934e 
Travis: PHP-7 is no longer allowed to fail
weierophinney added a commit that referenced this pull request May 12, 2016
@weierophinney
Merge branch 'hotfix/74'
2c68def 
Close #74
weierophinney added a commit that referenced this pull request May 12, 2016
@weierophinney
Merge branch 'hotfix/74' into develop
5a242ab 
Forward port #74
@marc-mabe marc-mabe mentioned this pull request May 27, 2016
Closed
@marc-mabe marc-mabe deleted the travis_php7 branch February 11, 2017 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marc-mabe @Ocramius @weierophinney