Fixes #2745 (generate proper query strings).#2774
Conversation
|
That build failure is not my fault... |
|
I think a better approach would be to allow specifying the character to use for the arg separator. Right now, the issue you're addressing is specific to your implementation -- and that may be true for other users. Some might use ";" or "+" for argument separation, and this change would not help them in the least. Would you be interested in helping make that happen? It'd be an additional option to pass to the client, and we'd read that option and use it in this location. If the option is not provided, we'd default to the php.ini setting. |
|
Will do. I'll post another PR tomorrow. |
|
@demonkoryu You can push the changes to the same branch, and they'll show up in this PR. And yes -- |
|
@weierophinney Done. |
- Tested default argument separator - Tested that argument separator may be provided - Provided functional test indicating provided argument separator is used
|
I added unit tests, and fixed an issue in the process. Merged against develop branch, as it introduces a new method into the API; will release with 2.1. |
- Tested default argument separator - Tested that argument separator may be provided - Provided functional test indicating provided argument separator is used
This fixes #2745 (generate proper query strings when arg_separator.output is set to e.g.
&).