Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

Fix trailing spaces CS error causing all travis builds to fail#3365

Merged
weierophinney merged 3 commits into
zendframework:developfrom
tca3:test-fix
Jan 7, 2013
Merged

Fix trailing spaces CS error causing all travis builds to fail#3365
weierophinney merged 3 commits into
zendframework:developfrom
tca3:test-fix

Conversation

@tca3
Copy link
Copy Markdown
Contributor

@tca3 tca3 commented Jan 7, 2013

ZendTest/Db/Sql/SelectTest.php (trailing_spaces) on every travis build from develop.

Fixed with this PR (hopefully).

@samsonasik
Copy link
Copy Markdown
Contributor

have you try

php php-cs-fixer.phar fix /path/to/dir --fixers=trailing_spaces 

?

@tca3
Copy link
Copy Markdown
Contributor Author

tca3 commented Jan 7, 2013

@samsonasik yea it's really strange, this PR is the output of php-cs-fixer and yet it tells me it's invalid.

@samsonasik
Copy link
Copy Markdown
Contributor

i think it's a travis problem, based on travis error, it's Timeouts

@tca3
Copy link
Copy Markdown
Contributor Author

tca3 commented Jan 7, 2013

@samsonasik One of them yes, the others are still trailing_spaces

weierophinney added a commit that referenced this pull request Jan 7, 2013
- used php-cs-fixer to remove trailing whitespace
@weierophinney weierophinney merged commit 3284fa7 into zendframework:develop Jan 7, 2013
@ghost ghost assigned weierophinney Jan 7, 2013
@tca3 tca3 deleted the test-fix branch January 7, 2013 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants