Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

Allow NULL parameter values in Zend/Json/Server #3767

Closed
wants to merge 3 commits into from
Closed

Allow NULL parameter values in Zend/Json/Server #3767

wants to merge 3 commits into from

Conversation

djskinner
Copy link
Contributor

See #3696 and
#2752

@Maks3w
Copy link
Member

Maks3w commented Feb 13, 2013

@djskinner Various things.

  • doing rebase -i HEAD~3 you should able to remove the extra commit.
  • Check your lineendings all the file looks changed. The correct lineending for ZF2 is "\n"

@ralphschindler
Copy link
Member

@djskinner if you can clean this up, we can evaluation its inclusion in 2.1.2

@ghost ghost assigned ralphschindler Feb 19, 2013
@weierophinney
Copy link
Member

@djskinner I would love to include this, but:

  • I need a unit test detailing the behavior (it will also be used to ensure we don't have a future regression in behavior)
  • I need you to fix the line endings, so that the patch only shows what has changed. Right now, I have no idea where the change is.

@djskinner djskinner closed this Feb 26, 2013
@djskinner djskinner reopened this Feb 26, 2013
@djskinner
Copy link
Contributor Author

Just in the process of tidying this up and doing it properly.

Daniel Skinner added 2 commits February 26, 2013 15:54
Allow NULL parameter values in Zend/Json/Server
28492a8 
Allow NULL as an acceptable value for non-optional method parameters.
Added test case
b12dd9f
@djskinner
Copy link
Contributor Author

@Maks3w @ralphschindler @weierophinney

Ok guys, pull request tidied and test case added. Anything else?

Maks3w
Maks3w reviewed Feb 28, 2013
View reviewed changes
tests/ZendTest/Json/ServerTest.php
@@ -259,6 +259,20 @@ public function testHandleValidMethodShouldWork()
$this->assertFalse($response->isError());
}

public function testHandleValidMethodWithNULLParamValueShouldWork()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check this character, should be 4 spaces and now is a tab

@Maks3w
Copy link
Member

Maks3w commented Feb 28, 2013

For me is good. I'll let the final decision to @ralphschindler

@djskinner The main reason for this delay is that GitHub doesn't notify us when a PR is modified. Just notify for comments.

@djskinner
Copy link
Contributor Author

I've added another commit to fix the formatting issue.

@ghost ghost assigned weierophinney Mar 1, 2013
weierophinney added a commit that referenced this pull request Mar 1, 2013
@weierophinney
[#3767] CS fixes
ed5baa6 
- indentation, trailing_spaces
weierophinney added a commit that referenced this pull request Mar 1, 2013
@weierophinney
Merge branch 'hotfix/3767' into develop
d883690 
Forward port #3767
weierophinney added a commit to zendframework/zend-json that referenced this pull request May 15, 2015
@weierophinney
[zendframework/zendframework#3767] CS fixes
2a2cbdb 
- indentation, trailing_spaces
weierophinney added a commit to zendframework/zend-json that referenced this pull request May 15, 2015
@weierophinney
Merge branch 'hotfix/3767'
f3c55cf 
Close zendframework/zendframework#3767
Fixes zendframework/zendframework#3696
Fixes zendframework/zendframework#2752
weierophinney added a commit to zendframework/zend-json that referenced this pull request May 15, 2015
@weierophinney
Merge branch 'hotfix/3767' into develop
6d4e64c 
Forward port zendframework/zendframework#3767
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@weierophinney weierophinney

Labels
None yet
Projects
None yet
Milestone
2.1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@djskinner @Maks3w @ralphschindler @weierophinney