This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Hotfix/zend test with console route#4010
Closed
blanchonvincent wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
I will test with regex, it's will be more clean. |
|
FYI I worked on this last night and came up with the following code (using a regex): if ($this->useConsoleRequest) {
preg_match_all('/(--\S+[= ]"\S*\s*\S*")|(--\S+=\S+|--\S+\s\S+|\S+)/', $url, $matches);
$params = str_replace(array(' "', '"'), array('=', ''), $matches[0]);
$request->params()->exchangeArray($params);
return $this;
} |
Contributor
Author
|
I change the PR with the regex and add test case. @farnoux Thank you for your help ! |
|
My pleasure! Glad it helped :) |
weierophinney
added a commit
that referenced
this pull request
Mar 12, 2013
…onsole-route Hotfix/zend test with console route
curious-eyes
pushed a commit
to curious-eyes/zf2
that referenced
this pull request
Mar 18, 2013
- trailing whitespace
weierophinney
added a commit
to zendframework/zend-test
that referenced
this pull request
May 15, 2015
…ent/hotfix/zend-test-with-console-route Hotfix/zend test with console route
weierophinney
added a commit
to zendframework/zend-test
that referenced
this pull request
May 15, 2015
- trailing whitespace
weierophinney
added a commit
to zendframework/zend-test
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-test
that referenced
this pull request
May 15, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix split on space to retrieve argument console. I used array and temporary string to fix, but i am sure a regex can be better.